Merged
Conversation
Reviewer's GuideIntroduce support for the policy-controller-operator by extending test constants, adding new image parsing logic and utilities, updating snapshot patterns, adding dedicated acceptance tests for the policy controller operator, and updating README instructions accordingly. Class diagram for new and updated test structure supporting policy controller operatorclassDiagram
class AcceptanceSuite {
}
class OperatorImagesTest {
}
class FBCImagesTest {
}
class ReleasesImagesTest {
}
class TestConstants {
+POLICY_CONTROLLER_OPERATOR_IMAGE
+POLICY_CONTROLLER_OPERATOR_TEST_PATH
}
class ImageUtils {
+ParsePolicyControllerOperatorImages()
}
AcceptanceSuite <|-- PCOAcceptanceSuite
PCOAcceptanceSuite : +setup()
PCOAcceptanceSuite : +teardown()
PCOAcceptanceSuite : +runPolicyControllerOperatorTests()
PCOAcceptanceSuite <|-- FBCImagesTest
PCOAcceptanceSuite <|-- OperatorImagesTest
PCOAcceptanceSuite <|-- ReleasesImagesTest
TestConstants <.. PCOAcceptanceSuite
ImageUtils <.. PCOAcceptanceSuite
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- There’s a mismatch between the constant PolicyControllerOperatorImageKey ("policy-controller-operator-image") and the key returned by MandatoryPcoOperatorImageKeys ("policy-controller-image")—you’ll want to unify those names so lookups don’t fail.
- ParsePCOperatorImages duplicates much of the logic in ParseOperatorImages—consider extracting a shared parsing helper or using a YAML parser instead of a broad regex to reduce duplication.
- The regex in ParsePCOperatorImages (
repository:\s*…[\s\S]+?) is very greedy and brittle; switching to a structured YAML unmarshal for the values.yaml file would be more reliable.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There’s a mismatch between the constant PolicyControllerOperatorImageKey ("policy-controller-operator-image") and the key returned by MandatoryPcoOperatorImageKeys ("policy-controller-image")—you’ll want to unify those names so lookups don’t fail.
- ParsePCOperatorImages duplicates much of the logic in ParseOperatorImages—consider extracting a shared parsing helper or using a YAML parser instead of a broad regex to reduce duplication.
- The regex in ParsePCOperatorImages (`repository:\s*…[\s\S]+?`) is very greedy and brittle; switching to a structured YAML unmarshal for the values.yaml file would be more reliable.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
JasonPowr
force-pushed
the
support-policy-controller-operator
branch
from
748acfd to
861ae5f
Compare
SequeI
approved these changes
Aug 27, 2025
JasonPowr
force-pushed
the
support-policy-controller-operator
branch
from
861ae5f to
98972ac
Compare
JasonPowr
force-pushed
the
support-policy-controller-operator
branch
from
98972ac to
c7fc9b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pr for the release repo also: https://github.com/securesign/releases/pull/154
Summary by Sourcery
Support policy controller operator in structural-tests by adding constants, parsing logic, regex updates, documentation updates, and a new set of acceptance tests.
New Features:
Enhancements:
Documentation:
Tests: